On 6/7/2016 5:40 PM, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com> > Signed-off-by: Maciej Czekaj <maciej.czekaj at caviumnetworks.com> > Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski at caviumnetworks.com> > Signed-off-by: Zyta Szpak <zyta.szpak at semihalf.com> > Signed-off-by: Slawomir Rosek <slawomir.rosek at semihalf.com> > Signed-off-by: Radoslaw Biernacki <rad at semihalf.com>
... > +static inline int > +nicvf_start_tx_queue(struct rte_eth_dev *dev, uint16_t qidx) > +{ > + struct nicvf_txq *txq; > + int ret; > + > + if (dev->data->tx_queue_state[qidx] == > + RTE_ETH_QUEUE_STATE_STARTED) Is line wrap required? ... > > static inline int > nicvf_configure_cpi(struct rte_eth_dev *dev) > @@ -912,6 +960,24 @@ nicvf_dev_rx_queue_stop(struct rte_eth_dev *dev, > uint16_t qidx) > } > > static int > +nicvf_dev_tx_queue_start(struct rte_eth_dev *dev, uint16_t qidx) > +{ > + if (qidx >= nicvf_pmd_priv(dev)->eth_dev->data->nb_tx_queues) > + return -EINVAL; This check already done by librte_ether > + > + return nicvf_start_tx_queue(dev, qidx); > +} > + > +static int > +nicvf_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t qidx) > +{ > + if (qidx >= nicvf_pmd_priv(dev)->eth_dev->data->nb_tx_queues) > + return -EINVAL; Same here > + > + return nicvf_stop_tx_queue(dev, qidx); > +} > + ...