On 6/7/2016 5:40 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> Signed-off-by: Maciej Czekaj <maciej.czekaj at caviumnetworks.com>
> Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski at caviumnetworks.com>
> Signed-off-by: Zyta Szpak <zyta.szpak at semihalf.com>
> Signed-off-by: Slawomir Rosek <slawomir.rosek at semihalf.com>
> Signed-off-by: Radoslaw Biernacki <rad at semihalf.com>
> ---
> drivers/net/thunderx/nicvf_ethdev.c | 175
> ++++++++++++++++++++++++++++++++++++
> drivers/net/thunderx/nicvf_rxtx.c | 18 ++++
> drivers/net/thunderx/nicvf_rxtx.h | 1 +
> 3 files changed, 194 insertions(+)
>
> diff --git a/drivers/net/thunderx/nicvf_ethdev.c
> b/drivers/net/thunderx/nicvf_ethdev.c
> index 5da07da..ba32803 100644
> --- a/drivers/net/thunderx/nicvf_ethdev.c
> +++ b/drivers/net/thunderx/nicvf_ethdev.c
> @@ -88,6 +88,8 @@ static int nicvf_dev_rss_hash_update(struct rte_eth_dev
> *dev,
> struct rte_eth_rss_conf *rss_conf);
> static int nicvf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
> struct rte_eth_rss_conf *rss_conf);
> +static int nicvf_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t qidx);
> +static int nicvf_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t qidx);
These declarations not required, there are more usages in other patches.
...
>
> static int
> +nicvf_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t qidx)
> +{
> + int ret;
> +
> + if (qidx >= nicvf_pmd_priv(dev)->eth_dev->data->nb_rx_queues)
> + return -EINVAL;
This check already done by librte_ether
> +
> + ret = nicvf_start_rx_queue(dev, qidx);
> + if (ret)
> + return ret;
> +
> + ret = nicvf_configure_cpi(dev);
> + if (ret)
> + return ret;
> +
> + return nicvf_configure_rss_reta(dev);
> +}
> +
> +static int
> +nicvf_dev_rx_queue_stop(struct rte_eth_dev *dev, uint16_t qidx)
> +{
> + int ret;
> +
> + if (qidx >= nicvf_pmd_priv(dev)->eth_dev->data->nb_rx_queues)
> + return -EINVAL;
Same for this case
> +
> + ret = nicvf_stop_rx_queue(dev, qidx);
> + ret |= nicvf_configure_cpi(dev);
> + ret |= nicvf_configure_rss_reta(dev);
> + return ret;
> +}
> +
...
