2016-07-27 10:08, Dumitrescu, Cristian: > As Thomas mentioned, today is probably the last day to discuss ABI changes. > This one is pretty small and straightforward, any issues with it? > > Panu had a concern that the change from "char *" to "const char *" is too > small to be regarded as ABI breakage and we should simply go ahead and do it. > My conservative proposal was to put a notice anyway. > > Nonetheless, what I would like to get from Thomas and Panu is a path forward > for this now: > a) If we agree to consider this an ABI change, please merge the notice for > 16.7;
Panu was noticing 3 things (and I agree with them): - it is an API change - they can be grouped in only one list item - it is better to wait having more changes to break an API About the third point, in this specific case, I think it is acceptable because: - it should not break the ABI - the impact of the API change is really small - I'm not sure the packet framework should be considered as a DPDK API. > b) If we agree this is too small for an ABI change, please let us agree now > to accept our quick patch for 16.11 for this change. For an API deprecation notice (reworded), Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com> > > -----Original Message----- > > The ABI changes are planned for rte_port_source_params and > > rte_port_sink_params, which will be supported from release 16.11. Here > > announces that ABI changes in detail. > > > > Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com> > > --- > > +* ABI will change for rte_port_source_params struct. The member > > file_name > > + data type will be changed from char * to const char *. This change > > targets > > + release 16.11 > > + > > +* ABI will change for rte_port_sink_params struct. The member file_name > > + data type will be changed from char * to const char *. This change > > targets > > + release 16.11
