As Thomas mentioned, today is probably the last day to discuss ABI changes. This one is pretty small and straightforward, any issues with it?
Panu had a concern that the change from "char *" to "const char *" is too small to be regarded as ABI breakage and we should simply go ahead and do it. My conservative proposal was to put a notice anyway. Nonetheless, what I would like to get from Thomas and Panu is a path forward for this now: a) If we agree to consider this an ABI change, please merge the notice for 16.7; b) If we agree this is too small for an ABI change, please let us agree now to accept our quick patch for 16.11 for this change. Thanks, Cristian > -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, May 19, 2016 3:19 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: announce ABI change of struct > rte_port_source_params and rte_port_sink_params > > The ABI changes are planned for rte_port_source_params and > rte_port_sink_params, which will be supported from release 16.11. Here > announces that ABI changes in detail. > > Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index fffe9c7..4f3fefe 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -74,3 +74,11 @@ Deprecation Notices > a handle, like the way kernel exposes an fd to user for locating a > specific file, and to keep all major structures internally, so that > we are likely to be free from ABI violations in future. > + > +* ABI will change for rte_port_source_params struct. The member > file_name > + data type will be changed from char * to const char *. This change targets > + release 16.11 > + > +* ABI will change for rte_port_sink_params struct. The member file_name > + data type will be changed from char * to const char *. This change targets > + release 16.11 > -- > 2.5.5
