On 01/21/2016 10:18 AM, Wojciech Andralojc wrote: > Patch reworked. > > Signed-off-by: Wojciech Andralojc <wojciechx.andralojc at intel.com> > --- > lib/librte_eal/common/include/arch/x86/rte_msr.h | 88 +++++++++++++++++ > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/arch/x86/rte_msr.c | 116 > +++++++++++++++++++++++ > 3 files changed, 205 insertions(+) > create mode 100644 lib/librte_eal/common/include/arch/x86/rte_msr.h > create mode 100644 lib/librte_eal/linuxapp/eal/arch/x86/rte_msr.c
This creates a new arch-specific public API, with rte_msr.h installed as a public header and implementation in the library (as opposed to inline), and so the new functions would have to be added to rte_eal_version.map. However that is a bit of a problem since it only exists on IA architectures, so it'd mean dummy entries in the version map for all other architectures. All the other arch-specific APIs are inline code so this is the first of its kind. Jerin Jacob suggested [1] adding these as internal (inline) functions which to me looks like a more sensible approach, arch-specific APIs tend to be problematic. [1] http://dpdk.org/ml/archives/dev/2016-January/031095.html - Panu -
