Hi Konstantin,
On 1/15/2016 11:03 PM, Ananyev, Konstantin wrote:
>
>> -----Original Message-----
>> From: Tan, Jianfeng
>> Sent: Friday, January 15, 2016 5:46 AM
>> To: dev at dpdk.org
>> Cc: Zhang, Helin; Ananyev, Konstantin; Tan, Jianfeng
>> Subject: [PATCH v2 01/12] ethdev: add API to query packet type filling info
>>
>> Add a new API rte_eth_dev_get_ptype_info to query wether/what packet type
>> will
>> be filled by given pmd rx burst function.
>>
>> Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com>
>> ---
>> lib/librte_ether/rte_ethdev.c | 20 ++++++++++++++++++++
>> lib/librte_ether/rte_ethdev.h | 27 +++++++++++++++++++++++++++
>> lib/librte_mbuf/rte_mbuf.h | 6 ++++++
>> 3 files changed, 53 insertions(+)
>>
>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
>> index ed971b4..cd34f46 100644
>> --- a/lib/librte_ether/rte_ethdev.c
>> +++ b/lib/librte_ether/rte_ethdev.c
>> @@ -1614,6 +1614,26 @@ rte_eth_dev_info_get(uint8_t port_id, struct
>> rte_eth_dev_info *dev_info)
>> dev_info->driver_name = dev->data->drv_name;
>> }
>>
>> +int
>> +rte_eth_dev_get_ptype_info(uint8_t port_id, uint32_t ptype_mask,
>> + uint32_t ptypes[], int num)
>> +{
>> + int ret, i, j;
>> + struct rte_eth_dev *dev;
>> + uint32_t all_ptypes[RTE_PTYPE_MAX_NUM];
>> +
>> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>> + dev = &rte_eth_devices[port_id];
>> + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_ptype_info_get, -ENOTSUP);
>> + ret = (*dev->dev_ops->dev_ptype_info_get)(dev, all_ptypes);
>> +
>> + for (i = 0, j = 0; i < ret && j < num; ++i)
>> + if (all_ptypes[i] & ptype_mask)
>> + ptypes[j++] = all_ptypes[i];
>> +
>> + return ret;
> I think it needs to be something like:
>
> j = 0;
> for (i = 0, j = 0; i < ret; ++i) {
> if (all_ptypes[i] & ptype_mask) {
> if (j < num)
> ptypes[j] = all_ptypes[i];
> j++;
> }
> }
>
> return j;
>
> Konstantin
>
You are right, my previous code is wrong.
But I have a concern about your code above: under the condition that the
caller does not provide big enough array to store adequate ptypes, it
has no way to return the not-enough-memory message back to caller.
So under that condition, how about we just return -ENOMEM?
Thanks,
Jianfeng
