> From: Stephen Hemminger [mailto:[email protected]] > Sent: Friday, 19 June 2026 17.40 > > On Fri, 19 Jun 2026 09:54:51 +0200 > Morten Brørup <[email protected]> wrote: > > > > > The problem with this patch it causes build failures now with abi > > > diff. > > > > > > It is probably a bug of an old version of abidiff. > > > I recommend updating. > > > > With the #define's the ABI has not changed. It's probably too > indirect for abidiff to understand. > > If we absolutely want to please abidiff, we could keep the existing > enums and #define RTE_LCORE_ROLE_RTE ROLE_RTE for now. > > But I'm in favor of what was done already. > > The build failures on github, not in my local builds. > https://github.com/ovsrobot/dpdk/actions/runs/27789889172/job/822359650 > 90 > > It makes looking at patchwork dashboard difficult, all patches show up > with red mark
So maybe we can choose the path of pleasing abidiff... Keep the existing enums, and #define the new RTE_LCORE_ prefixed variants, and use those in the code. Later, with an ABI breaking release, we can swap. Or maybe we just wait until an ABI breaking release to fix this.
