On Wed, 3 Jun 2026 08:47:38 +0300
Denis Sergeev <[email protected]> wrote:
> The IPv4 parsing helper used by pktgen and pktchkr reads each octet
> with "%u". This allows values above 255 to be accepted from the
> configuration file and encoded into unintended device register values.
>
> Reject parsed octets outside the IPv4 byte range before assembling
> the 32-bit address.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and
> pktgen")
>
> Signed-off-by: Denis Sergeev <[email protected]>
> ---
Have to ask, why a driver is rolling it own IP address parser, that is a bad
idea.
But then the whole builtin vendor pktgen in a driver is bad idea.
Claude scan of the driver found lots more issues.
Hate to think what Mythos would find here...
