On Tue, 30 Dec 2025 02:29:58 +0000 "Jasper Tran O'Leary" <[email protected]> wrote:
> Currently, the driver does not include any reset functionality and hence > cannot be reset by the application. This patch introduces a driver > callback for the `rte_eth_dev_reset` function which will reset the > device. > > Also, as a precaution, null out device pointers to rx and tx queue > arrays when we release the queues during a reset. > > Signed-off-by: Jasper Tran O'Leary <[email protected]> > Reviewed-by: Joshua Washington <[email protected]> > --- AI code review spotted some minor things, please provide an updated version. Patch 2: net/gve: add reset path Verdict: ⚠️ Needs minor fixes Commit Message: ✅ Subject line: 23 characters (within 60 limit) ✅ Correct prefix net/gve: ✅ Imperative mood, lowercase, no trailing period ✅ Signed-off-by and Reviewed-by present Warnings: Unnecessary initialization (line 45): int err = 0; — err is always assigned before use in gve_init_priv(). Should be just int err; Missing release notes: Adding dev_reset callback is a new feature. Per guidelines, new features/API additions should update doc/guides/rel_notes/ for the current release. Missing documentation: The PMD documentation in doc/guides/nics/gve.rst should be updated to reflect that reset is now supported, and doc/guides/nics/features/gve.ini should list the feature if applicable. Code: ✅ Good defensive check for secondary process ✅ Good check that device is stopped before reset ✅ Error handling is appropriate ✅ NULL-ing queue pointers after release is good practice
