2016-04-22 15:42, Stephen Hemminger: > On Fri, 22 Apr 2016 15:08:50 -0700 > Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote: > > On Fri, Apr 22, 2016 at 11:14:35PM +0200, Thomas Monjalon wrote: > > > rxd = (Vmxnet3_RxDesc *)rxq->cmd_ring[ring_idx].base + > > > idx; > > > + RTE_SET_USED(rxd); /* used only for assert when enabled */ > > > > How about adding the __rte_unused tag at where we declare it?
It is not really unused. And adding a SET_USED line allows to put a comment in the context below the assignment. > Why not just kill the useless assert's all together? They really only helped > during the short time developer is debugging this code. They also provide some kind of comments and can help when refactoring. Anyway, removing the assert would deserve another patch.
