On Fri, 11 Apr 2025 16:10:03 +0800 Chaoyong He <chaoyong...@corigine.com> wrote:
> From: Long Wu <long...@corigine.com> > > The command of setting VLAN filter IDs can only set one VLAN filter > ID at once. For example: > testpmd> rx_vlan add 100 0 > > This is very inefficient in some case because it forces the > user type this command as many times as the VLAN filter IDs > they want to set. > > This patch supports the user set any number valid VLAN filter > IDs just through one command and it is also backwards compatible. > For example: > testpmd> rx_vlan add 100,102-103,200 0 > The VLAN filter IDs 100, 102, 103, 200 will be added to port 0. > > Signed-off-by: Long Wu <long...@corigine.com> > Reviewed-by: Chaoyong He <chaoyong...@corigine.com> Not sure if this is really worth the effort. Testpmd is intended to exercise drivers, not as a production forwarding application though users have tendency to be lazy and use it for that. If consensus is to implement this, then DPDK should really have a way to parse a range of values (already needed for cores). Then the library code could be used here, rather than special parsing code only for VLAN's in testpmd.
