On Mon, Mar 03, 2025 at 03:19:49PM +0000, Bruce Richardson wrote:
> On Fri, Feb 28, 2025 at 10:45:56AM -0800, Andre Muezerie wrote:
> > Updated meson.build to use common variable cc_avx512_flags.
> >
> > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com>
> > ---
> > config/x86/meson.build | 2 +-
> > lib/acl/meson.build | 8 ++------
> > 2 files changed, 3 insertions(+), 7 deletions(-)
> >
>
> One suggested improvement below.
>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
>
> > diff --git a/config/x86/meson.build b/config/x86/meson.build
> > index 47a5b0c04a..12befd4d73 100644
> > --- a/config/x86/meson.build
> > +++ b/config/x86/meson.build
> > @@ -14,7 +14,7 @@ if is_linux or cc.get_id() == 'gcc'
> > endif
> > endif
> >
> > -cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw']
> > +cc_avx512_flags = ['-mavx512f', '-mavx512vl', '-mavx512dq', '-mavx512bw',
> > '-mavx512cd']
> > cc_has_avx512 = false
> > target_has_avx512 = false
> > if (binutils_ok and cc.has_multi_arguments(cc_avx512_flags)
> > diff --git a/lib/acl/meson.build b/lib/acl/meson.build
> > index fefe131a48..6ba53fbba4 100644
> > --- a/lib/acl/meson.build
> > +++ b/lib/acl/meson.build
> > @@ -55,15 +55,11 @@ if dpdk_conf.has('RTE_ARCH_X86')
> > sources += files('acl_run_avx512.c')
> > cflags += '-DCC_AVX512_SUPPORT'
> >
> > - elif cc.has_multi_arguments('-mavx512f', '-mavx512vl',
> > - '-mavx512cd', '-mavx512bw')
> > -
> > + elif cc.has_multi_arguments(cc_avx512_flags)
>
> existing variable "cc_has_avx512"?
Indeed, that is even better. I sent out an updated patch.
>
> > avx512_tmplib = static_library('avx512_tmp',
> > 'acl_run_avx512.c',
> > dependencies: static_rte_eal,
> > - c_args: cflags +
> > - ['-mavx512f', '-mavx512vl',
> > - '-mavx512cd', '-mavx512bw'])
> > + c_args: cflags + cc_avx512_flags)
> > objs += avx512_tmplib.extract_objects(
> > 'acl_run_avx512.c')
> > cflags += '-DCC_AVX512_SUPPORT'
> > --
> > 2.48.1.vfs.0.0
> >
