Reviewing zxdh driver these are some obvious things that could be fixed Stephen Hemminger (5): net/zxdh: remove __rte_unused from function prototypes net/zxdh: remove __rte_unused attribute net/zxdh: fix RTE_ASSERT expression net/zxdh: make callback table const and static net/zxdh: fix indentation in mtr get and use assign
drivers/net/zxdh/zxdh_ethdev.c | 2 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 2 +- drivers/net/zxdh/zxdh_ethdev_ops.h | 10 ++++------ drivers/net/zxdh/zxdh_msg.c | 24 ++++++++++-------------- drivers/net/zxdh/zxdh_msg.h | 1 - drivers/net/zxdh/zxdh_mtr.c | 30 +++++++++++++++--------------- drivers/net/zxdh/zxdh_mtr.h | 4 ++-- drivers/net/zxdh/zxdh_np.h | 2 +- drivers/net/zxdh/zxdh_queue.h | 4 ++-- drivers/net/zxdh/zxdh_rxtx.h | 6 ++---- 10 files changed, 38 insertions(+), 47 deletions(-) -- 2.47.2
