On error path, the journal socket code would call close
with -1 which caused Coverity warning.

Coverity issue: 448872
Fixes: 9da0dc6c0331 ("log: support systemd journal")

Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
 lib/log/log_journal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/log/log_journal.c b/lib/log/log_journal.c
index e9b3aa5640..43099649ed 100644
--- a/lib/log/log_journal.c
+++ b/lib/log/log_journal.c
@@ -116,7 +116,7 @@ log_journal_open(const char *id)
                .sun_family = AF_UNIX,
                .sun_path = "/run/systemd/journal/socket",
        };
-       int jfd = -1;
+       int jfd;
 
        len = snprintf(syslog_id, sizeof(syslog_id),
                       "SYSLOG_IDENTIFIER=%s\nSYSLOG_PID=%u", id, getpid());
@@ -128,7 +128,7 @@ log_journal_open(const char *id)
        jfd = socket(AF_UNIX, SOCK_DGRAM, 0);
        if (jfd < 0) {
                perror("socket");
-               goto error;
+               return NULL;
        }
 
        if (connect(jfd, (struct sockaddr *)&sun, sizeof(sun)) < 0) {
-- 
2.47.2

Reply via email to