Looks good. Just some very small comments on polishing.
Reviewed-by: Luca Vizzarro <luca.vizza...@arm.com>
On 31/01/2025 19:38, Nicholas Pratte wrote:
Forwarding restarts in the run-time MTU adjustment test case have been
explicitly added, given that the 'requires_forwarding_restart' decorator
from a previous patch was removed.
Signed-off-by: Nicholas Pratte <npra...@iol.unh.edu>
---
dts/tests/TestSuite_mtu.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/dts/tests/TestSuite_mtu.py b/dts/tests/TestSuite_mtu.py
index 3c96a36fc9..d1d48c2c13 100644
--- a/dts/tests/TestSuite_mtu.py
+++ b/dts/tests/TestSuite_mtu.py
@@ -164,20 +164,26 @@ def test_runtime_mtu_updating_and_forwarding(self) ->
None:
# Configure the new MTU.
# Start packet capturing.
- testpmd.start()
I guess all of the lines above are no longer needed here.
testpmd.set_port_mtu_all(1500, verify=True)
+ testpmd.start()
self.assess_mtu_boundary(testpmd, 1500)
+ testpmd.stop()
testpmd.set_port_mtu_all(2400, verify=True)
+ testpmd.start()
self.assess_mtu_boundary(testpmd, 1500)
self.assess_mtu_boundary(testpmd, 2400)
+ testpmd.stop()
testpmd.set_port_mtu_all(4800, verify=True)
+ testpmd.start()
self.assess_mtu_boundary(testpmd, 1500)
self.assess_mtu_boundary(testpmd, 4800)
+ testpmd.stop()
testpmd.set_port_mtu_all(9000, verify=True)
+ testpmd.start()
self.assess_mtu_boundary(testpmd, 1500)
self.assess_mtu_boundary(testpmd, 9000)
The start and stop could be grouped by forwarding sections:
set_mtu()
start()
assess()
assess()
stop()
set_mtu()
...
