On Wed, Dec 11, 2024 at 11:07 PM Andre Muezerie
<andre...@linux.microsoft.com> wrote:
>
> Many places are using a GCC extension related to variadic macros,
> where a name prepends the ellipsis. This results in a warning like
> the one below when compiling the code with MSVC:
>
> app\test-pmd\testpmd.h(1314): error C2608:
> invalid token '...' in macro parameter list
>
> Variadic macros became a standard part of the C language with C99.
> GCC, Clang and MSVC handle them properly.
>
> The fix is to remove the prefix name (args... becomes ...) and use
> __VA_ARGS__.
>
> v2:
> * Removed "do { } while (0)" that was added to macros in v1. As a
> result, the patchset is now smaller.
>
> Andre Muezerie (14):
> app/test-acl: use portable variadic macros
> app/test-eventdev: use portable variadic macros
> app/test-mldev: use portable variadic macros
> app/test-pmd: use portable variadic macros
> drivers/bus: use portable variadic macros
> drivers/common: use portable variadic macros
> drivers/compress: use portable variadic macros
> drivers/crypto: use portable variadic macros
> drivers/dma: use portable variadic macros
> drivers/event: use portable variadic macros
> drivers/mempool: use portable variadic macros
> drivers/net: use portable variadic macros
> drivers/raw: use portable variadic macros
> drivers/vdpa: use portable variadic macros
>
> app/test-acl/main.c | 4 +-
> app/test-eventdev/evt_common.h | 12 ++--
> app/test-mldev/ml_common.h | 7 ++-
> app/test-pmd/testpmd.h | 4 +-
> drivers/bus/cdx/cdx_logs.h | 12 ++--
> drivers/bus/dpaa/include/fman.h | 4 +-
> drivers/bus/dpaa/rte_dpaa_logs.h | 18 +++---
> drivers/bus/fslmc/fslmc_logs.h | 12 ++--
> drivers/bus/fslmc/qbman/include/compat.h | 14 ++---
> drivers/bus/ifpga/ifpga_logs.h | 16 ++---
> drivers/bus/uacce/uacce.c | 8 +--
> drivers/common/dpaax/compat.h | 16 ++---
> drivers/common/dpaax/dpaax_logs.h | 18 +++---
> drivers/common/idpf/base/idpf_osdep.h | 8 ++-
> drivers/compress/octeontx/otx_zip.h | 8 +--
> drivers/compress/zlib/zlib_pmd_private.h | 12 ++--
> drivers/crypto/caam_jr/caam_jr_log.h | 28 ++++-----
> drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 28 ++++-----
> drivers/crypto/dpaa_sec/dpaa_sec_log.h | 28 ++++-----
> drivers/crypto/virtio/virtio_logs.h | 60 +++++++++----------
> drivers/dma/dpaa/dpaa_qdma_logs.h | 24 ++++----
> drivers/dma/dpaa2/dpaa2_qdma_logs.h | 24 ++++----
> drivers/dma/idxd/idxd_internal.h | 8 +--
> drivers/dma/ioat/ioat_internal.h | 8 +--
> drivers/event/dlb2/dlb2_log.h | 8 +--
> drivers/event/dlb2/pf/base/dlb2_osdep.h | 12 ++--
> drivers/event/dpaa/dpaa_eventdev.h | 16 ++---
> drivers/event/dpaa2/dpaa2_eventdev_logs.h | 12 ++--
> drivers/event/dsw/dsw_evdev.h | 8 +--
> drivers/event/sw/sw_evdev_log.h | 12 ++--
> drivers/mempool/dpaa/dpaa_mempool.h | 20 +++----
> drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 30 +++++-----
> drivers/net/ark/ark_logs.h | 4 +-
> drivers/net/bnxt/tf_core/cfa_tcam_mgr.h | 12 ++--
> drivers/net/bnxt/tf_core/tfp.h | 8 +--
> drivers/net/bnxt/tf_ulp/bnxt_tf_common.h | 4 +-
> drivers/net/dpaa/dpaa_ethdev.h | 16 ++---
> drivers/net/dpaa/fmlib/fm_ext.h | 4 +-
> drivers/net/dpaa2/dpaa2_pmd_logs.h | 28 ++++-----
> drivers/net/e1000/base/e1000_osdep.h | 10 ++--
> drivers/net/ena/base/ena_plat_dpdk.h | 14 ++---
> drivers/net/enetc/enetc_logs.h | 32 +++++-----
> drivers/net/enetfec/enet_pmd_logs.h | 18 +++---
> drivers/net/enic/enic_compat.h | 16 ++---
> drivers/net/fm10k/base/fm10k_osdep.h | 10 ++--
> drivers/net/hns3/hns3_logs.h | 20 +++----
> drivers/net/i40e/base/i40e_osdep.h | 2 +-
> drivers/net/ice/base/ice_osdep.h | 4 +-
> drivers/net/igc/base/igc_osdep.h | 10 ++--
> drivers/net/ipn3ke/ipn3ke_logs.h | 16 ++---
> drivers/net/ixgbe/base/ixgbe_osdep.h | 30 +++++-----
> drivers/net/ngbe/base/ngbe_osdep.h | 2 +-
> drivers/net/ngbe/ngbe_logs.h | 2 +-
> drivers/net/pfe/pfe_logs.h | 18 +++---
> drivers/net/qede/qede_ethdev.h | 4 +-
> drivers/net/qede/qede_logs.h | 16 ++---
> drivers/net/sfc/sfc_debug.h | 4 +-
> drivers/net/txgbe/base/txgbe_osdep.h | 2 +-
> drivers/net/txgbe/txgbe_logs.h | 2 +-
> drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h | 24 ++++----
> drivers/raw/ifpga/base/opae_debug.h | 4 +-
> drivers/raw/ifpga/base/opae_osdep.h | 20 +++----
> .../raw/ifpga/base/osdep_rte/osdep_generic.h | 4 +-
> drivers/raw/ifpga/ifpga_rawdev.h | 16 ++---
> drivers/raw/skeleton/skeleton_rawdev.h | 16 ++---
> drivers/raw/skeleton/skeleton_rawdev_test.c | 8 +--
> drivers/vdpa/ifc/base/ifcvf_osdep.h | 4 +-
> 67 files changed, 453 insertions(+), 450 deletions(-)
Thanks for the cleanup André, the series lgtm.
Applied, thanks.
--
David Marchand
