Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it.
Therefore the errors below are seen with MSVC:

../lib/mldev/mldev_utils_scalar.c(465): error C2065:
    '__SIZEOF_LONG__': undeclared identifier
../lib/mldev/mldev_utils_scalar.c(478): error C2051:
    case expression not constant

../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065:
    '__SIZEOF_LONG__': undeclared identifier
../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051:
    case expression not constant

Turns out that the places where __SIZEOF_LONG__ is currently
being used can equally well use sizeof(long) instead.

v3:
 * added prefix RTE_ to BITS_PER_LONG* and moved them to rte_common.h
 * defined PLT_BITS_PER_LONG* in drivers/common/cnxk/roc_platform.h to
   avoid warnings from checkpatches.sh like:

   Warning in drivers/common/cnxk/roc_bits.h:
   Warning in drivers/common/cnxk/roc_ie_ot.h:
   Warning in drivers/common/cnxk/roc_ie_ot_tls.h:
   Use plt_ symbols instead of rte_ API in cnxk base driver

   It can be seen that the same was done in the past for similar
   macros like PLT_CACHE_LINE_SIZE

v2:
 * fixed typo in commit message

Andre Muezerie (7):
  lib/eal: eliminate dependency on non-portable __SIZEOF_LONG__
  drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__
  drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__
  drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__
  drivers/net: eliminate dependency on non-portable __SIZEOF_LONG__
  drivers/raw: eliminate dependency on non-portable __SIZEOF_LONG__
  lib/mldev: eliminate dependency on non-portable __SIZEOF_LONG__

 drivers/bus/fslmc/mc/fsl_mc_cmd.h      |  3 +--
 drivers/common/cnxk/cnxk_security_ar.h |  4 ++--
 drivers/common/cnxk/roc_bits.h         | 13 ++++---------
 drivers/common/cnxk/roc_ie_ot.h        |  4 ++--
 drivers/common/cnxk/roc_ie_ot_tls.h    |  5 +++--
 drivers/common/cnxk/roc_platform.h     |  2 ++
 drivers/common/nfp/nfp_platform.h      |  8 +++-----
 drivers/dma/dpaa/dpaa_qdma.h           |  3 +--
 drivers/dma/hisilicon/hisi_dmadev.h    |  3 +--
 drivers/net/ena/base/ena_plat_dpdk.h   |  6 ++----
 drivers/net/hns3/hns3_ethdev.h         |  3 +--
 drivers/raw/ifpga/base/opae_osdep.h    | 12 ++++--------
 lib/eal/include/rte_common.h           |  5 +++++
 lib/mldev/mldev_utils_scalar.h         |  6 +-----
 14 files changed, 32 insertions(+), 45 deletions(-)

--
2.47.0.vfs.0.3

Reply via email to