On Tue, 19 Nov 2024 10:02:23 +0800
Jiawen Wu <jiawe...@trustnetic.com> wrote:
> On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote:
> > On 11/15/2024 8:33 AM, Jiawen Wu wrote:
> > > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by
> > > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity
> > > is set to 0xd by default too, which means these interrupts are rising-edge
> > > sensitive.
> > >
> > > So when unplug the SFP module, GPIO line 0 'tx_fault' is 0 -> 1 triggers
> > > the interrupt. However, the interrupt is not cleared. And GPIO interrupt
> > > mask is enabled and disabled to trigger the MISC interrupt repeatedly.
> > >
> > > Since this 'tx_fault' interrupt does not make much sense, simply clear it
> > > to fix the issue.
> > >
> > > Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com>
> > >
> >
> > Hi Jiawen,
> >
> > Can you please provide a fixes tag?
> > Also I believe you would like to backport this fix, if so please add the
> > stable tag as well.
>
> I have thought about it. But there are two changes based on two commits:
> 1. d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification")
> 2. 12011b11a3d6 ("net/txgbe: adapt to MNG veto bit setting")
>
> Should I split the patch and add fixes tags separately?
>
>
It is ok, as is. I can add the fixes tag for you.
The purpose of the fixes is to help with discovering patches that need
to go into stable.
Applied to next-net
