On 19/11/2024 16:31, Dean Marx wrote:
So... this is a weird one. I've integrated the code generation under
dts-check-format.sh, so nobody should really worry about it, as that
should be run before submitting. If it's not, then the CI will
eventually pick it up when dts-check-format will be in place.
Right, and that definitely makes sense logically but I think maybe
even just throwing in a comment in conf.yaml similar to the one you
used below (timeout: 20 # optional field from
HelloWorldConfig) would be beneficial, even if just to show where the
customized fields should go. If you'd rather leave it as is though
that's totally fine with me, this is kind of a nitpick suggestion
anyways
Oh ok, yes it makes sense. It's a good shout. Although, this patchset
may change how it will be once we start splitting the configuration file
in multiple ones. I guess we'll see what happens then! This will
probably stay on standby until we reach an agreement on what to do.
Thank you for your review!
Luca
