> So... this is a weird one. I've integrated the code generation under
> dts-check-format.sh, so nobody should really worry about it, as that
> should be run before submitting. If it's not, then the CI will
> eventually pick it up when dts-check-format will be in place.

Right, and that definitely makes sense logically but I think maybe
even just throwing in a comment in conf.yaml similar to the one you
used below (timeout: 20               # optional field from
HelloWorldConfig) would be beneficial, even if just to show where the
customized fields should go. If you'd rather leave it as is though
that's totally fine with me, this is kind of a nitpick suggestion
anyways

> The hello_world suite doesn't really need this, I've just added it as an
> example. But yes test suites are affected. If you see the hello_world
> suite, it calls `self.config.timeout` which is a reference to this
> field. This class specifically is now wholly integrated in the
> configuration:

Okay that makes sense, thanks Luca!

Reply via email to