Hi Thomas, Thanks a lot for helping merge these patches. We apologize for the inconvenience caused to you resolving the issues. We'll be more vigilant in future reviews to avoid similar disruptions.
Regards, Vanshika > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Sunday, November 10, 2024 7:04 AM > To: Vanshika Shukla <vanshika.shu...@nxp.com>; Gagandeep Singh > <g.si...@nxp.com>; Hemant Agrawal <hemant.agra...@nxp.com>; Jun > Yang <jun.y...@nxp.com>; Rohit Raj <rohit....@nxp.com> > Cc: dev@dpdk.org; David Marchand <david.march...@redhat.com> > Subject: [EXT] Re: [v5 00/42] DPAA2 specific patches > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > 23/10/2024 13:59, vanshika.shu...@nxp.com: > > Apeksha Gupta (2): > > net/dpaa2: add proper MTU debugging print > > net/dpaa2: store drop priority in mbuf > > > > Brick Yang (1): > > net/dpaa2: update DPNI link status method > > > > Gagandeep Singh (3): > > bus/fslmc: upgrade with MC version 10.37 > > net/dpaa2: fix memory corruption in TM > > net/dpaa2: support software taildrop > > > > Hemant Agrawal (2): > > net/dpaa2: add support to dump dpdmux counters > > bus/fslmc: change dpcon close as internal symbol > > > > Jun Yang (23): > > net/dpaa2: enhance Tx scatter-gather mempool > > net/dpaa2: add new PMD API to check dpaa platform version > > bus/fslmc: improve BMAN buffer acquire > > bus/fslmc: get MC VFIO group FD directly > > bus/fslmc: enhance MC VFIO multiprocess support > > bus/fslmc: dynamic IOVA mode configuration > > bus/fslmc: remove VFIO IRQ mapping > > bus/fslmc: create dpaa2 device with it's object > > bus/fslmc: introduce VFIO DMA mapping API for fslmc > > net/dpaa2: flow API refactor > > net/dpaa2: dump Rx parser result > > net/dpaa2: enhancement of raw flow extract > > net/dpaa2: frame attribute flags parser > > net/dpaa2: add VXLAN distribution support > > net/dpaa2: protocol inside tunnel distribution > > net/dpaa2: eCPRI support by parser result > > net/dpaa2: add GTP flow support > > net/dpaa2: check if Soft parser is loaded > > net/dpaa2: soft parser flow verification > > net/dpaa2: add flow support for IPsec AH and ESP > > net/dpaa2: check IOVA before sending MC command > > net/dpaa2: add API to get endpoint name > > net/dpaa2: dpdmux single flow/multiple rules support > > > > Rohit Raj (6): > > bus/fslmc: add close API to close DPAA2 device > > net/dpaa2: support link state for eth interfaces > > bus/fslmc: free VFIO group FD in case of add group failure > > bus/fslmc: fix coverity issue > > bus/fslmc: change qbman eq desc from d to desc > > net/dpaa2: change miss flow ID macro name > > > > Sachin Saxena (1): > > net/dpaa2: improve DPDMUX error behavior settings > > > > Vanshika Shukla (4): > > net/dpaa2: support PTP packet one-step timestamp > > net/dpaa2: dpdmux: add support for CVLAN > > net/dpaa2: support VLAN traffic splitting > > net/dpaa2: add support for C-VLAN and MAC > > This series is not clean at all. > There are a lot of unrelated changes in the middle of patches like reindent or > cast cleanup. > Some commits are breaking compilation. > Some useless code is added and removed in the last commit. > The features matrix for the flow items and actions are not updated. > Some error messages are polluting the cleanup stage for everybody. > The patch for DPDMUX based on C-VLAN and MAC address is present twice. > Not even talking about conflicts because of a parallel series. > > I'm not sure why I'm trying to merge these patches, I suppose I'm trying to be > kind. > I've fixed all blocking issues and applied. >
