This seems ok.
> -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Wednesday, October 23, 2024 6:23 AM > To: Vanshika Shukla <vanshika.shu...@nxp.com> > Cc: dev@dpdk.org; Hemant Agrawal <hemant.agra...@nxp.com>; Sachin > Saxena <sachin.sax...@nxp.com>; Jun Yang <jun.y...@nxp.com> > Subject: [EXT] Re: [v4 23/42] net/dpaa2: flow API refactor > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Wed, 23 Oct 2024 00:42:36 +0530 > vanshika.shu...@nxp.com wrote: > > > From: Jun Yang <jun.y...@nxp.com> > > > > 1) Gather redundant code with same logic from various protocol > > handlers to create common functions. > > 2) struct dpaa2_key_profile is used to describe each extract's > > offset of rule and size. It's easy to insert new extract previous > > IP address extract. > > 3) IP address profile is used to describe ipv4/v6 addresses extracts > > located at end of rule. > > 4) L4 ports profile is used to describe the ports positions and offsets > > of rule. > > 5) Once the extracts of QoS/FS table are update, go through all > > the existing flows of this table to update the rule data. > > > > Signed-off-by: Jun Yang <jun.y...@nxp.com> > > Before it looked possible to dump flow info to file, now it only goes to > stdout. > Is that ok?
