Dear Ferruh, Thank you for your comments. I will make the changes you suggested. Our DPDK PMD is developed based on our company’s Linux kernel drivers r8125 and r8126, which are more comprehensive and detailed. To facilitate synchronized maintenance, I have retained the CamelCase.
Best Regards, Howard Wang -----邮件原件----- 发件人: Ferruh Yigit <ferruh.yi...@amd.com> 发送时间: 2024年11月3日 10:24 收件人: 王颢 <howard_w...@realsil.com.cn>; dev@dpdk.org 抄送: pro_nic_d...@realtek.com 主题: Re: [PATCH v5 00/18] modify code as suggested by the maintainer External mail. On 10/28/2024 7:30 AM, Howard Wang wrote: > Fix some warning issues. > > Howard Wang (18): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r8169: add support for hw config > net/r8169: add phy registers access routines > net/r8169: add support for hardware operations > net/r8169: add support for phy configuration > net/r8169: add support for hw initialization > net/r8169: add link status and interrupt management > net/r8169: implement Rx path > net/r8169: implement Tx path > net/r8169: implement device statistics > net/r8169: implement promisc and allmulti modes > net/r8169: implement MTU configuration > net/r8169: add support for getting fw version > net/r8169: add driver_start and driver_stop > doc/guides/nics: add documents for r8169 pmd > Hi Howard, Thanks for restructuring the patch series, it looks better now, I put some comments. Btw, there are many "Avoid CamelCase" checkpatch warning, if this code is not shared (but developed for DPDK), can you please address the warnings?
