2024-10-28 12:45 (UTC-0700), Andre Muezerie:
> Enhance build instructions on Windows
Commit messages should explain why the previous state had been problematic
and how the new state solves the issues. For example:
doc: modernize build instructions on Windows
Meson 0.57 was an unstable version and is now outdated.
The referenced bug in Meson 0.58 is fixed in stable releases.
Recommend the latest stable release which is tested.
...likewise about command prompt changes...
[...]
> @@ -129,11 +126,23 @@ Depending on the distribution, paths in this file may
> need adjustments.
> Option 3. Native Build on Windows using MSVC
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> -Open a 'Developer PowerShell for VS 2022' prompt from the start menu.
> +Open a 'Visual Studio Developer Command Prompt'.
> The developer prompt will configure the environment
> to select the appropriate compiler, linker and SDK paths
> required to build with Visual Studio 2022.
>
> +Windows 32-bit is currently not supported, so if your Visual Studio
> environment defaults
> +to 32-bits you can instruct the toolset to produce 64-bit binaries using
> "-arch" parameter.
> +For more details about the Developer Prompt options look at the `Visual
> Studio Developer
> +Command Prompt and Developer PowerShell
> +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_.
> +
> +.. code-block:: console
> +
> + "C:\Program Files\Microsoft Visual
> Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64
> +
> +Compile the code from the developer prompt.
> +
> .. code-block:: console
>
> cd C:\Users\me\dpdk
It will be unclear to the reader to which machine "32-bit" refers.
Suggestion:
Building DPDK applications that run on 32-bit Windows is currently not
supported. If your Visual Studio environment defaults to producing
32-bit binaries...
With the above corrections,
Acked-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com>
