2024-10-25 12:30 (UTC-0700), Andre Muezerie: > Signed-off-by: Andre Muezerie <andre...@linux.microsoft.com> > --- > doc/guides/windows_gsg/build_dpdk.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/windows_gsg/build_dpdk.rst > b/doc/guides/windows_gsg/build_dpdk.rst > index c5fad81..76bfc22 100644 > --- a/doc/guides/windows_gsg/build_dpdk.rst > +++ b/doc/guides/windows_gsg/build_dpdk.rst > @@ -74,7 +74,7 @@ A good option to choose is the MSI installer for both meson > and ninja together:: > > Meson version 0.58 was unusable with LLVM toolchain > because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but > -more recent versions are working fine. > +more recent versions are working fine. Meson version 1.5.2 was tested and > worked. > > > Install the Backend
In order to address reviewer feedback on a single patch, you are supposed to send an updated version of that patch, not a series of the original patch (as v2 1/2) and a patch with amendments (as v2 2/2, i.e. this patch). IOW, you should have sent a single v2 patch with the proper text. As for this documentation paragraph: please drop the mention of Meson 0.58 and simply state that Meson 1.5.2 or newer is recommended. The warning was put in place because the bug lasted many Meson versions.
