On Thu, Oct 17, 2024 at 09:53:18AM +0200, David Marchand wrote: > On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > > This patchset proposed increasing the minimum meson version to 0.57 > > and makes changes to update our build files appropriately for that > > change: replacing deprecated functions, removing unnecessary version > > checks and taking advantage of some new capabilities. > > > > Why 0.57? No one particular reason; it's mainly a conservative version > > bump that doesn't have many impacts, but still gives us the minimum > > updates we need to replace the deprecated get_cross_properties fn > > and have a few extra features guaranteed available. > > > > Bruce Richardson (5): > > build: increase minimum meson version to 0.57 > > build: remove version check on compiler links function > > build: remove unnecessary version checks > > build: use version file support from meson > > build: replace deprecated meson function > > > > .ci/linux-setup.sh | 2 +- > > config/arm/meson.build | 4 ++-- > > config/meson.build | 8 ++++---- > > config/riscv/meson.build | 4 ++-- > > doc/api/meson.build | 2 +- > > doc/guides/linux_gsg/sys_reqs.rst | 2 +- > > doc/guides/prog_guide/build-sdk-meson.rst | 2 +- > > drivers/common/qat/meson.build | 2 +- > > drivers/crypto/ipsec_mb/meson.build | 2 +- > > drivers/event/cnxk/meson.build | 2 +- > > drivers/meson.build | 7 ++----- > > drivers/net/cnxk/meson.build | 2 +- > > lib/meson.build | 6 ------ > > meson.build | 7 ++----- > > 14 files changed, 20 insertions(+), 32 deletions(-) > > The series looks good, and CI guys gave me the green light. > Series applied, thanks Bruce. > > > There is one remaining TODO in config/meson.build: > > # MS linker requires special treatment. > # TODO: use cc.get_linker_id() with Meson >= 0.54 > is_ms_compiler = is_windows and (cc.get_id() == 'msvc') > is_ms_linker = is_windows and (cc.get_id() == 'clang' or > is_ms_compiler) >
Yep. I'm hoping perhaps one of the windows maintainers/devs could look at this because I see a number of possible linker values for windows listed in the table at [1] and I'm not 100% sure which ones are to be accepted here. /Bruce [1] https://mesonbuild.com/Reference-tables.html#linker-ids
