On Tue, Oct 8, 2024 at 7:31 PM Vladimir Medvedkin
<vladimir.medved...@intel.com> wrote:
>
> AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and
> RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding
> if vector function can be used.
>

Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup")

> Cc: sta...@dpdk.org
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medved...@intel.com>

Reviewed-by: David Marchand <david.march...@redhat.com>

I wish we had a build check for those.
Or maybe a tool/script that would look at libraries/drivers, catch
_mmXXXXX intrinsics and warn if such a library/driver has no call to
corresponding runtime check.
That would save us from having to go to
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html
...

Could someone from Intel work on this?


In any case, adjusted indent, fixed Fixes: tag, removed superfluous
parenthesis, and applied, thanks.

-- 
David Marchand

Reply via email to