> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Wednesday, 11 September 2024 01.48 > > On 9/10/2024 5:56 PM, Morten Brørup wrote: > > It would be convenient if the CI checked that the symbols in > version.map files actually exist in the resulting code. > > > > Is there instances that is not the case?
While reviewing a patch, I noticed one such instance. A previous version of the patch contained a global variable that had since been removed, but not from the version.map file. Specifically "rte_lcore_var" in this earlier version: https://patchwork.dpdk.org/project/dpdk/patch/20240208181644.455233-2-mattias.ronnb...@ericsson.com/ Which in this more recent patch has been removed, but remains in version.map: https://patchwork.dpdk.org/project/dpdk/patch/20240910070344.699183-2-mattias.ronnb...@ericsson.com/