On 7/23/2024 3:26 PM, Gavin Li wrote:
> VXLAN-GPE support was removed from testpmd recently. Drivers which are
> not migrated are still using VXLAN-GPE in tests.
> 
> This commit is to restore the support for VXLAN-GPE in testpmd.
> 
> After this change, there are two command line items with the same name, ie.
> "protocol". One is for the new VXLAN extensions and the other is for the
> deprecated VXLAN-GPE. Add a new one that is more obvious for the new VXLAN
> structure since the two have different command line context.
> 
> Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field")
>
> Signed-off-by: Gavin Li <gav...@nvidia.com>
>

Acked-by: Ferruh Yigit <ferruh.yi...@amd.com>

<...>

> @@ -423,6 +424,13 @@ enum index {
>       ITEM_GENEVE_VNI,
>       ITEM_GENEVE_PROTO,
>       ITEM_GENEVE_OPTLEN,
> +     ITEM_VXLAN_GPE,
> +     ITEM_VXLAN_GPE_VNI,
> +     /* Used for "struct rte_vxlan_gpe_hdr", deprecated, prefer 
> ITEM_VXLAN_GPE_PROTO */
> +     ITEM_VXLAN_GPE_PROTO_IN_DEPRECATED_VXLAN_GPE_HDR,
>

This is an ugly name :), but it suits to purpose, it has innate property
that makes you want to remove it.


Applied to dpdk-next-net/main, thanks.


Please remember sending deprecation notice before -rc4, thanks.

Reply via email to