I just noticed one mistake in a doc-comment. Otherwise however, good work. Reviewed-by: Jeremy Spewock <jspew...@iol.unh.edu>
On Thu, Jul 18, 2024 at 3:40 PM Nicholas Pratte <npra...@iol.unh.edu> wrote: > > The mac address filter test suite, whose test cases are based on old > DTS's test cases, has been refactored to interface with the new DTS > framework. > > In porting over this test suite into the new framework, some > adjustments were made, namely in the EAL and TestPMD parameter provided > before executing the application. While the original test plan was > referenced, by and large, only for the individual test cases, I'll leave > the parameters the original test plan was asking for below for the sake > of discussion: > > --burst=1 --rxpt=0 --rxht=0 --rxwt=0 --txpt=36 --txht=0 --txwt=0 > --txfreet=32 --rxfreet=64 --mbcache=250 --portmask=0x3 > > Bugzilla ID: 1454 > Signed-off-by: Nicholas Pratte <npra...@iol.unh.edu> > > --- <snip> > + def send_packet_and_verify( > + self, > + mac_address: str, > + add_vlan: bool = False, > + should_receive: bool = True, > + ) -> None: > + """Generate, send, and verify a packet based on specified parameters. > + > + Test cases within this suite utilize this method to create, send, > and verify > + packets based on criteria relating to the packet's destination mac > address, > + vlan tag, and whether or not the packet should be received or not. > Packets > + are verified using an inserted payload. Assuming the test case > expects to > + receive a specified packet, if the list of received packets contains > this > + payload within any of its packets, the test case passes. > Alternatively, if > + the designed packet should not be received, and the packet payload > is not, I like this addition, but I just noticed that an additional comma snuck in after the "not" at the end of the line here. > + received, then the test case fails. Each call with this method sends > exactly > + one packet. > + > + Args: > + mac_address: The destination mac address of the packet being > sent. > + add_vlan: If :data:'True', add a vlan tag to the packet being > sent. The > + vlan tag will be :data:'2' if the packet should be received > and > + :data:'1' if the packet should not be received but requires > a vlan tag. > + should_receive: If :data:'True', assert whether or not the sent > packet > + has been received. If :data:'False', assert that the send > packet was not > + received. :data:'True' by default > + """ <snip> >
