Hi, Slava
> 1. The absolute max descriptor number supported by ConnectX hardware is 32768.
> 2. The actual max descriptor number supported by the port (and its related
> representors)
> reported in log_max_wq_sz in HCA.caps. This value should be queried and
> save in mlx5_devx_cmd_query_hca_attr() routine.
> 3. mlx5_rx_queue_pre_setup() should check requested descriptor number and
> reject if it exceeds log_max_wq_sz
Thank you for the guidelines! I've also added the same check to
mlx5_tx_queue_pre_setup(),
I'm assuming log_max_wq_sz can be used for both RX and TX.
Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` is
sufficient, but I've left it
an `int` for consistency with the other `log_max_*` values.
Also, I've noticed a similar issue with MTU, it is also reported as 65535 in
`rte_eth_dev_info.max_mtu`. I'd like to send a separate patch to fix that too.
What's
the procedure for reading max supported MTU?
> 4. Please, format your patch according to the "fix" template.
I've reworded the commit message a little bit. But I don't see these issues on
Bugzilla, I've
stumbled upon them independently. If you'd like the bug reports to be created,
let me know.
Sincerely,
Igor
Igor Gutorov (1):
net/mlx5: fix incorrect rx/tx descriptor limitations in
rte_eth_dev_info
drivers/common/mlx5/mlx5_devx_cmds.c | 1 +
drivers/common/mlx5/mlx5_devx_cmds.h | 1 +
drivers/net/mlx5/mlx5_ethdev.c | 4 ++++
drivers/net/mlx5/mlx5_rxq.c | 8 ++++++++
drivers/net/mlx5/mlx5_txq.c | 8 ++++++++
5 files changed, 22 insertions(+)
--
2.45.2
