On Mon, Apr 01, 2024 at 07:53:48PM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2024 02:14:06 +0000 > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> wrote: > > > > On Apr 1, 2024, at 9:00 PM, Stephen Hemminger > > > <step...@networkplumber.org> wrote: > > > > > > On Tue, 2 Apr 2024 01:35:28 +0000 > > > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> wrote: > > > > > >>> On Apr 1, 2024, at 7:47 PM, Stephen Hemminger > > >>> <step...@networkplumber.org> wrote: > > >>> > > >>> On Mon, 1 Apr 2024 22:28:52 +0000 > > >>> Aditya Ambadipudi <aditya.ambadip...@arm.com> wrote: > > >>> > > >>>> Thanks, Stephen, for the comment. > > >>>> > > >>>> Unfortunately, we don't have the dev setup nor the resources to test > > >>>> out this change using MSVC. > > >>>> > > >>>> Thank you, > > >>>> Aditya Ambadipudi > > >>> > > >>> All it requires is the community version of MSVC which is free. And > > >>> setting up a Windows > > >>> VM with KVM is free and easy. > > >>> > > >>> IMHO all new libraries have to build on all environments, unless they > > >>> are enabling > > >>> platform specific features. > > >> I see that UNH CI is running Windows VMs, the tests are passing there. > > >> So, we do not need to anything. > > >> > > > > > > That only tests the clang part. > > > You need to modify lib/meson.build to get it tested with the windows > > > compiler. > > Any idea on when is this getting added to CI? > > You need to add this to next version of the patch. > I tried it and MSVC has no problems with the new code. > > Another issue is the naming. Right now the choice of 'deque' generates lots of > checkpatch errors, and every bit of new code that uses the library will get a > warning > as well. Can you think of a better name? > > diff --git a/lib/meson.build b/lib/meson.build > index 8c8c1e98e2..127e4dc68c 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -75,6 +75,7 @@ if is_ms_compiler > 'kvargs', > 'telemetry', > 'eal', > + 'deque', > 'ring', > ] > endif
please do this. thanks
