On Mon, Mar 25, 2024 at 12:35 PM Jerin Jacob <jerinjac...@gmail.com> wrote: > > On Mon, Mar 25, 2024 at 4:45 PM Robin Jarry <rja...@redhat.com> wrote: > > > > Jerin Jacob, Mar 25, 2024 at 12:08: > > > > It will not be taken into account for MSVC. Is that OK? > > > > > > Why?. rte_mbuf has a similar scheme. > > > RTE_MARKER cacheline1 __rte_cache_min_aligned; > > > > RTE_MARKER* types seem not defined for the MSVC toolchain.
There is some work in progress to stop using those markers. https://patchwork.dpdk.org/project/dpdk/list/?series=31579&state=* > > > > https://github.com/DPDK/dpdk/blob/v24.03-rc4/lib/eal/include/rte_common.h#L589-L602 > > Hmm. Not sure, how mbuf is building for MSCV tool chain then. Atm, MSVC builds a really small list of libraries. http://git.dpdk.org/dpdk/tree/lib/meson.build#n71?id=v24.03-rc4 if is_ms_compiler libraries = [ 'log', 'kvargs', 'telemetry', 'eal', 'ring', ] endif > > Another option could be to have a helper inline function/macro to take > care of casting to make app code clean of casting. That could be an option. -- David Marchand
