On Mon, Mar 25, 2024 at 05:05:12PM +0530, Jerin Jacob wrote: > On Mon, Mar 25, 2024 at 4:45 PM Robin Jarry <rja...@redhat.com> wrote: > > > > Jerin Jacob, Mar 25, 2024 at 12:08: > > > > It will not be taken into account for MSVC. Is that OK? > > > > > > Why?. rte_mbuf has a similar scheme. > > > RTE_MARKER cacheline1 __rte_cache_min_aligned; > > > > RTE_MARKER* types seem not defined for the MSVC toolchain. > > > > https://github.com/DPDK/dpdk/blob/v24.03-rc4/lib/eal/include/rte_common.h#L589-L602 > > Hmm. Not sure, how mbuf is building for MSCV tool chain then. > > Another option could be to have a helper inline function/macro to take > care of casting to make app code clean of casting.
The markers are being removed from DPDK and being replaced by more portable, and more standards-conforming constructs. We should not be adding more markers to existing structures. See [1] /Bruce [1] https://patches.dpdk.org/project/dpdk/list/?series=31579
