21/03/2024 12:05, Tummala, Sivaprasad: > From: Thomas Monjalon <tho...@monjalon.net> > > 19/03/2024 08:24, Morten Brørup: > > > > From: Sivaprasad Tummala [mailto:sivaprasad.tumm...@amd.com] > > > > Sent: Monday, 18 March 2024 18.32 > > > > > > > > Currently the config option allows lcore IDs up to 255, irrespective > > > > of RTE_MAX_LCORES and needs to be fixed. > > > > > > > > The patch allows config options based on DPDK config. > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > Cc: sta...@dpdk.org > > > > > > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tumm...@amd.com> > > > > Acked-by: Konstantin Ananyev <konstantin.anan...@huawei.com> > > > > --- > > > > > > I suggest you update the description of the individual patches too, like > > > you did > > for patch 0/6. > > > > > > E.g. this patch not only fixes the lcore_id, but also the queue_id type > > > size. > > > > > > > > > For the series, > > > Acked-by: Morten Brørup <m...@smartsharesystems.com> > > > > I would recommend a separate patch for queue id as it is a separate issue. > > However, there is no need to split per directory. > > You can have patches changing all examples at once. > > > There's a functional dependency and queue id change is required to support > higher lcore IDs and hence it makes sense to add in the same patch. > I had split the examples to help the maintainers review the patches > individually. > Please feel free to squash the git commits while merging.
Then if there is a dependency, please make queue id the first patch.
