Hi Stephen,
It messed with the indentation, didn't it?
Thanks
Nic
> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Friday, March 1, 2024 9:15 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <step...@networkplumber.org>; Chautru, Nicolas
> <nicolas.chau...@intel.com>
> Subject: [PATCH v2 33/71] baseband/acc: replace use of fixed size
> rte_memcpy
>
> Automatically generated by devtools/cocci/rte_memcpy.cocci
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> drivers/baseband/acc/rte_acc100_pmd.c | 17 ++++++++---------
> drivers/baseband/acc/rte_vrb_pmd.c | 21 ++++++++++-----------
> 2 files changed, 18 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
> b/drivers/baseband/acc/rte_acc100_pmd.c
> index 4f666e514b72..6a6212f3deed 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -2975,15 +2975,13 @@ enqueue_ldpc_dec_one_op_cb(struct
> acc_queue *q, struct rte_bbdev_dec_op *op,
> uint8_t *prev_ptr = (uint8_t *) prev_desc;
> uint8_t *new_ptr = (uint8_t *) desc;
> /* Copy first 4 words and BDESCs */
> - rte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);
> - rte_memcpy(new_ptr + ACC_5GUL_OFFSET_0,
> - prev_ptr + ACC_5GUL_OFFSET_0,
> - ACC_5GUL_SIZE_1);
> + memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);
> + memcpy(new_ptr + ACC_5GUL_OFFSET_0,
> + prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1);
> desc->req.op_addr = prev_desc->req.op_addr;
> /* Copy FCW */
> - rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET,
> - prev_ptr + ACC_DESC_FCW_OFFSET,
> - ACC_FCW_LD_BLEN);
> + memcpy(new_ptr + ACC_DESC_FCW_OFFSET,
> + prev_ptr + ACC_DESC_FCW_OFFSET,
> ACC_FCW_LD_BLEN);
> acc100_dma_desc_ld_update(op, &desc->req, input,
> h_output,
> &in_offset, &h_out_offset,
> &h_out_length, harq_layout);
> @@ -3130,7 +3128,8 @@ enqueue_ldpc_dec_one_op_tb(struct acc_queue
> *q, struct rte_bbdev_dec_op *op,
> desc = acc_desc(q, total_enqueued_cbs);
> desc->req.data_ptrs[0].address = q->ring_addr_iova +
> fcw_offset;
> desc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN;
> - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld,
> ACC_FCW_LD_BLEN);
> + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld,
> + ACC_FCW_LD_BLEN);
> ret = acc100_dma_desc_ld_fill(op, &desc->req, &input,
> h_output, &in_offset, &h_out_offset,
> &h_out_length,
> @@ -4430,7 +4429,7 @@ acc100_configure(const char *dev_name, struct
> rte_acc_conf *conf)
> struct acc_device *d = bbdev->data->dev_private;
>
> /* Store configuration */
> - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));
> + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));
>
> value = acc_reg_read(d, HwPfPcieGpexBridgeControl);
> bool firstCfg = (value != ACC100_CFG_PCI_BRIDGE); diff --git
> a/drivers/baseband/acc/rte_vrb_pmd.c
> b/drivers/baseband/acc/rte_vrb_pmd.c
> index 88b1104fab47..3e5376a12e39 100644
> --- a/drivers/baseband/acc/rte_vrb_pmd.c
> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
> @@ -2450,15 +2450,13 @@ vrb_enqueue_ldpc_dec_one_op_cb(struct
> acc_queue *q, struct rte_bbdev_dec_op *op,
> uint8_t *prev_ptr = (uint8_t *) prev_desc;
> uint8_t *new_ptr = (uint8_t *) desc;
> /* Copy first 4 words and BDESCs. */
> - rte_memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);
> - rte_memcpy(new_ptr + ACC_5GUL_OFFSET_0,
> - prev_ptr + ACC_5GUL_OFFSET_0,
> - ACC_5GUL_SIZE_1);
> + memcpy(new_ptr, prev_ptr, ACC_5GUL_SIZE_0);
> + memcpy(new_ptr + ACC_5GUL_OFFSET_0,
> + prev_ptr + ACC_5GUL_OFFSET_0, ACC_5GUL_SIZE_1);
> desc->req.op_addr = prev_desc->req.op_addr;
> /* Copy FCW. */
> - rte_memcpy(new_ptr + ACC_DESC_FCW_OFFSET,
> - prev_ptr + ACC_DESC_FCW_OFFSET,
> - ACC_FCW_LD_BLEN);
> + memcpy(new_ptr + ACC_DESC_FCW_OFFSET,
> + prev_ptr + ACC_DESC_FCW_OFFSET,
> ACC_FCW_LD_BLEN);
> vrb_dma_desc_ld_update(op, &desc->req, input, h_output,
> &in_offset, &h_out_offset,
> &h_out_length, harq_layout);
> @@ -2566,7 +2564,8 @@ vrb_enqueue_ldpc_dec_one_op_tb(struct
> acc_queue *q, struct rte_bbdev_dec_op *op,
> fcw_offset = (desc_idx << 8) + ACC_DESC_FCW_OFFSET;
> desc->req.data_ptrs[0].address = q->ring_addr_iova +
> fcw_offset;
> desc->req.data_ptrs[0].blen = ACC_FCW_LD_BLEN;
> - rte_memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld,
> ACC_FCW_LD_BLEN);
> + memcpy(&desc->req.fcw_ld, &desc_first->req.fcw_ld,
> + ACC_FCW_LD_BLEN);
> desc->req.fcw_ld.tb_trailer_size = (c - r - 1) * trail_len;
> ret = vrb_dma_desc_ld_fill(op, &desc->req, &input,
> h_output, &in_offset, &h_out_offset, @@ -
> 3991,7 +3990,7 @@ enqueue_mldts_split_op(struct acc_queue *q, struct
> rte_bbdev_mldts_op *op,
> if (symb == 0)
> desc->req.cbs_in_tb = num_syms;
> else
> - rte_memcpy(&desc->req.fcw_mldts, fcw,
> ACC_FCW_MLDTS_BLEN);
> + memcpy(&desc->req.fcw_mldts, fcw,
> ACC_FCW_MLDTS_BLEN);
> desc->req.data_ptrs[1].address =
> rte_pktmbuf_iova_offset(input_q, in_offset);
> desc->req.data_ptrs[1].blen = q_size;
> in_offset += q_size;
> @@ -4337,7 +4336,7 @@ vrb1_configure(const char *dev_name, struct
> rte_acc_conf *conf)
> struct acc_device *d = bbdev->data->dev_private;
>
> /* Store configuration. */
> - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));
> + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));
>
> /* Check we are already out of PG. */
> status = acc_reg_read(d, VRB1_PfHiSectionPowerGatingAck); @@ -
> 4744,7 +4743,7 @@ vrb2_configure(const char *dev_name, struct
> rte_acc_conf *conf)
> struct acc_device *d = bbdev->data->dev_private;
>
> /* Store configuration. */
> - rte_memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));
> + memcpy(&d->acc_conf, conf, sizeof(d->acc_conf));
>
> /* Explicitly releasing AXI as this may be stopped after PF FLR/BME.
> */
> address = VRB2_PfDmaAxiControl;
> --
> 2.43.0
