The function rand is very weak and should not be used.
Use the DPDK rte_rand() which is seeded from entropy instead.
Coverity issue: 414987
Fixes: b3d326e438f1 ("baseband/fpga_5gnr_fec: add FPGA mutex")
Cc: hernan.var...@intel.com
Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index efc1d3a7725b..9b253cde280d 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -14,6 +14,7 @@
#include <bus_pci_driver.h>
#include <rte_byteorder.h>
#include <rte_cycles.h>
+#include <rte_random.h>
#include <rte_bbdev.h>
#include <rte_bbdev_pmd.h>
@@ -1990,7 +1991,7 @@ fpga_5gnr_mutex_acquisition(struct fpga_5gnr_queue *q)
{
uint32_t mutex_ctrl, mutex_read, cnt = 0;
/* Assign a unique id for the duration of the DDR access */
- q->ddr_mutex_uuid = rand();
+ q->ddr_mutex_uuid = rte_rand();
/* Request and wait for acquisition of the mutex */
mutex_ctrl = (q->ddr_mutex_uuid << 16) + 1;
do {
--
2.43.0
