> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Monday, February 5, 2024 15:03 > To: Dariusz Sosnowski <dsosnow...@nvidia.com> > Cc: Slava Ovsiienko <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; > Suanming Mou <suanmi...@nvidia.com>; Matan Azrad > <ma...@nvidia.com>; Ferruh Yigit <ferruh.yi...@amd.com>; Andrew > Rybchenko <andrew.rybche...@oktetlabs.ru>; dev@dpdk.org > Subject: Re: [PATCH v2] ethdev: fast path async flow API > > External email: Use caution opening links or attachments > > > 05/02/2024 14:14, Dariusz Sosnowski: > > From: Thomas Monjalon <tho...@monjalon.net> > > > 31/01/2024 10:35, Dariusz Sosnowski: > > > > As a result, no checks for availability of the implementation are > > > > needed at library level in data path. > > > > Any library-level validation checks in async flow API are compiled > > > > if and only if RTE_FLOW_DEBUG macro is defined. > > > > > > How are we supposed to enable RTE_FLOW_DEBUG? > > > > I should document it, but the idea was that it must be explicitly > > enabled during build, by adding -c_args=-DRTE_FLOW_DEBUG to meson > options. > > > > Do you think doc/guides/nics/build_and_test.rst is a good place to > document this option? > > Yes > > > It would be documented alongside RTE_ETHDEV_DEBUG_RX and > RTE_ETHDEV_DEBUG_TX. > > > > > May it be enabled automatically if other debug option is globally enabled? > > > > Do you mean that if buildtype is defined as debug, then RTE_FLOW_DEBUG > is defined automatically? > > Yes > > > I think that's a good idea. > > Another way of enabling it is to check > #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG I think that defining RTE_FLOW_DEBUG based on buildtype would be more appropriate, since the code under RTE_FLOW_DEBUG is not responsible for any additional logging or tracing. It rather serves as basic checks for all async flow API functions.
Best regards, Dariusz Sosnowski
