On Sat, Jan 20, 2024 at 12:18:38PM +0800, 1819846787 wrote: > I have modified my commitlog and resubmitted the patch, but I seem to > have forgotten to add a [v2] flag to the patch. Do I need to resubmit > the patch again? >
It's better if the v2 is added, but it's probably not necessary in this case. However, I see now you have resubmitted as a v2 anyway, which is fine. Please mark older versions of the patch as "superceded" in patchwork (patches.dpdk.org site - you'll need an account created with the email address used to submit your patches. That will allow you to update the status of your own patches yourself) Also, one other tip, when submitting a new version of a previously reviewed patch, unless there are major changes, you can keep any previously added acks from reviewers. For your v2, for example, after your signed-off-by you could have also added the "Acked-by: Ciara Power ... " line. Hope these tips help in the future! Thanks for the contribution. /Bruce > ------------------ ԭʼʼ� ------------------ > > ����: "David Marchand"<david.march...@redhat.com>; > ��ʱ�: 2024119() 11:54 > ռ�: " "<1819846...@qq.com>; > ��: "dev"<dev@dpdk.org>; "ciara.power"<ciara.po...@intel.com>; "Bruce > Richardson"<bruce.richard...@intel.com>; > : Re: [PATCH] lib/telemetry:fix telemetry conns leak in case of socket > write fail > > Hello, > On Fri, Jan 19, 2024 at 12:40�6�2PM sunshaowei01 <[1]1819846...@qq.com> > wrote: > > > > Telemetry can only create 10 conns by default, each of which is > processed > > by a thread. > > > > When a thread fails to write using socket, the thread will end > directly > > without reducing the total number of conns. > > > > This will result in the machine running for a long time, and if there > are > > 10 failures, the telemetry will be unavailable > > > Thanks for the patch, do you know which commit first triggered the > issue? > This is needed so we add a Fixes: tag in the commitlog for backporting > the fix in stable releases. > See > [2]https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-rela > ted-issues > > Signed-off-by: sunshaowei01 <[3]1819846...@qq.com> > We need your full name in the SoB tag. > Like, for example in my case, it would be David Marchand > <[4]david.march...@redhat.com>. > -- > David Marchand > > References > > 1. mailto:1819846...@qq.com > 2. > https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related-issues > 3. mailto:1819846...@qq.com > 4. mailto:david.march...@redhat.com
