On 8/29/2015 2:51 AM, Pavel Boldin wrote: > * Move ioctl `EVENTFD_COPY' code to a separate function > * Remove extra #includes > * Introduce function fget_from_files > * Fix ioctl return values > > Signed-off-by: Pavel Boldin <pboldin at mirantis.com> Basically OK with this patch since we have reviewed before. Could you split the patch, one change each patch? Thomas will require you to do this too. :). I see you have also changed when to call put_files_struct. It is better put it in a separate patch with the reason. Another thing is code style. Run checkpatch.pl against your patch. There are some issues.
- [dpdk-dev] [PATCH v5 2/4] vhost: add EVENTFD_COPY... Xie, Huawei
- [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_CO... Pavel Boldin
- [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_CO... Xie, Huawei
- [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_CO... Pavel Boldin
- [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_CO... Xie, Huawei
- [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_CO... Pavel Boldin
- [dpdk-dev] [PATCH v5 4/4] DO NOT MERGE: Tests for... Pavel Boldin
- [dpdk-dev] [PATCH v5 1/4] vhost: eventfd_link: re... Pavel Boldin
- [dpdk-dev] [PATCH v5 1/4] vhost: eventfd_link: re... Thomas Monjalon
- [dpdk-dev] [PATCH v5 1/4] vhost: eventfd_link: re... Pavel Boldin
- [dpdk-dev] [PATCH v5 1/4] vhost: eventfd_link: re... Xie, Huawei
- [dpdk-dev] [PATCH v6 0/3] vhost: eventfd_link ref... Pavel Boldin
- [dpdk-dev] [PATCH v6 1/3] vhost: eventfd_link: re... Pavel Boldin
- [dpdk-dev] [PATCH v6 2/3] vhost: add EVENTFD_COPY... Pavel Boldin
- [dpdk-dev] [PATCH v6 3/3] vhost: using EVENTFD_CO... Pavel Boldin
- [dpdk-dev] [PATCH v6 0/3] vhost: eventfd_link ref... Xie, Huawei
- [dpdk-dev] [PATCH v6 0/3] vhost: eventfd_link ref... Thomas Monjalon
- [dpdk-dev] [PATCH v5 2/5] vhost: eventfd_link: add functio... Pavel Boldin
- [dpdk-dev] [PATCH v5 3/5] vhost: eventfd_link: fix ioctl r... Pavel Boldin
- [dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace cop... Pavel Boldin