> From: Mingjin Ye [mailto:mingjinx...@intel.com] > Sent: Thursday, 21 December 2023 11.14 > > The only way to enable diagnostics for TX paths is to modify the > application source code. Making it difficult to diagnose faults. > > In this patch, the devarg option "mbuf_check" is introduced and the > parameters are configured to enable the corresponding diagnostics.
Why not use the already existing RTE_LIBRTE_MBUF_DEBUG? > > supported cases: mbuf, size, segment, offload, strict. > 1. mbuf: check for corrupted mbuf. > 2. size: check min/max packet length according to hw spec. > 3. segment: check number of mbuf segments not exceed hw limitation. > 4. offload: check any unsupported offload flag. > 5. strict: check protocol headers. These are all good things to test for, when debugging. The checks should be part of RTE_LIBRTE_MBUF_DEBUG, instead of introducing yet another runtime parameter. Also, it would be better to add these checks somewhere in the ethdev library instead of in the individual drivers. That would make them available for all drivers. > > parameter format: mbuf_check=[mbuf,<case1>,<case2>] > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=[mbuf,size] -- -i > > Signed-off-by: Mingjin Ye <mingjinx...@intel.com> > ---
