On Thu, Dec 07, 2023 at 04:18:11PM +0000, Euan Bourke wrote:
> Add a new library to make it easier for eal and other libraries to parse
> command line arguments.
>
> The first function in this library is one to parse a corelist string
> into an array of individual core ids. The function will then return the
> total number of cores described in the corelist.
>
> Signed-off-by: Euan Bourke <euan.bou...@intel.com>
> ---
> .mailmap | 1 +
> MAINTAINERS | 4 ++
> doc/api/doxy-api-index.md | 3 +-
> doc/api/doxy-api.conf.in | 1 +
> lib/arg_parser/arg_parser.c | 108 ++++++++++++++++++++++++++++++++
> lib/arg_parser/meson.build | 7 +++
> lib/arg_parser/rte_arg_parser.h | 66 +++++++++++++++++++
> lib/arg_parser/version.map | 10 +++
> lib/meson.build | 2 +
> 9 files changed, 201 insertions(+), 1 deletion(-)
> create mode 100644 lib/arg_parser/arg_parser.c
> create mode 100644 lib/arg_parser/meson.build
> create mode 100644 lib/arg_parser/rte_arg_parser.h
> create mode 100644 lib/arg_parser/version.map
>
> diff --git a/.mailmap b/.mailmap
> index ab0742a382..528bc68a30 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -379,6 +379,7 @@ Eric Zhang <eric.zh...@windriver.com>
> Erik Gabriel Carrillo <erik.g.carri...@intel.com>
> Erik Ziegenbalg <ezieg...@brocade.com>
> Erlu Chen <erlu.c...@intel.com>
> +Euan Bourke <euan.bou...@intel.com>
> Eugenio Pérez <epere...@redhat.com>
> Eugeny Parshutin <eugeny.parshu...@linux.intel.com>
> Evan Swanson <evan.swan...@intel.com>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0d1c8126e3..68ef5ba14b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1756,6 +1756,10 @@ M: Nithin Dabilpuram <ndabilpu...@marvell.com>
> M: Pavan Nikhilesh <pbhagavat...@marvell.com>
> F: lib/node/
>
> +Argument parsing
> +M: Bruce Richardson <bruce.richard...@intel.com>
> +F: lib/arg_parser/
> +
>
> Test Applications
> -----------------
> diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> index a6a768bd7c..f711010140 100644
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -221,7 +221,8 @@ The public API headers are grouped by topics:
> [config file](@ref rte_cfgfile.h),
> [key/value args](@ref rte_kvargs.h),
> [string](@ref rte_string_fns.h),
> - [thread](@ref rte_thread.h)
> + [thread](@ref rte_thread.h),
> + [argument parsing](@ref rte_arg_parser.h)
>
> - **debug**:
> [jobstats](@ref rte_jobstats.h),
> diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> index e94c9e4e46..05718ba6ed 100644
> --- a/doc/api/doxy-api.conf.in
> +++ b/doc/api/doxy-api.conf.in
> @@ -28,6 +28,7 @@ INPUT =
> @TOPDIR@/doc/api/doxy-api-index.md \
> @TOPDIR@/lib/eal/include \
> @TOPDIR@/lib/eal/include/generic \
> @TOPDIR@/lib/acl \
> + @TOPDIR@/lib/arg_parser \
> @TOPDIR@/lib/bbdev \
> @TOPDIR@/lib/bitratestats \
> @TOPDIR@/lib/bpf \
> diff --git a/lib/arg_parser/arg_parser.c b/lib/arg_parser/arg_parser.c
> new file mode 100644
> index 0000000000..240f63d8e1
> --- /dev/null
> +++ b/lib/arg_parser/arg_parser.c
> @@ -0,0 +1,108 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2023 Intel Corporation
> + */
> +
> +#include "errno.h"
> +#include "stdlib.h"
> +#include "ctype.h"
> +#include "string.h"
> +#include "stdbool.h"
should be <> not "" quotes for system or standard library headers includes.
> +
> +#include <rte_arg_parser.h>
> +#include <rte_common.h>
> +
> +
> +struct core_bits {
> + uint8_t bits[(UINT16_MAX + 1) / CHAR_BIT];
> + uint16_t max_bit_set;
> + uint16_t min_bit_set;
> + uint32_t total_bits_set;
> +};
> +
> +static inline bool
> +get_core_bit(struct core_bits *mask, uint16_t idx)
nit: use size_t typed parameters for things that are used as an offset /
subscript value. applies to all instances in the series.
