>-----Original Message-----
>From: Thomas Monjalon <tho...@monjalon.net>
>Sent: Tuesday, November 28, 2023 9:25 PM
>To: Ankur Dwivedi <adwiv...@marvell.com>
>Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jer...@marvell.com>
>Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in
>checkpatch
>
>28/11/2023 15:07, Ankur Dwivedi:
>> >07/03/2023 13:05, Ankur Dwivedi:
>> >> This patch series adds a validation in checkpatch tool to check if
>> >> tracepoint is present in any new function added in ethdev, eventdev
>> >> cryptodev and mempool library.
>> >>
>> >> v5:
>> >> - Copied the build_map_changes function from check-symbol-change.sh
>to
>> >> check-tracepoint.sh.
>> >> - Added eventdev, cryptodev and mempool in libdir in check-
>tracepoint.sh.
>> >
>> >Why did you decide to copy the function in v5, instead of having a
>> >common file usable by different scripts?
>> >
>> There was comments in v2 of the patch that common scripts may not work
>well and to keep the scripts specialized.
>
>I meant you can have a common file specialized in symbols.
The build_map_changes() (in devtools/check-symbol-change.sh) which is a common
function can be moved to a new file named devtools/build-symbol-map.sh.
The build-symbol-map.sh can be included in check-symbol-change.sh and
check-tracepoint.sh.
Please let me know if this is fine.
>In general, you should reply, establish a discussion, so we share the same
>understanding.
>
