Reviewed-by: John Daley <johnd...@cisco.com>
Thanks,
John
From: Weiguo Li <liw...@foxmail.com>
Date: Wednesday, November 1, 2023 at 12:28 AM
To: John Daley (johndale) <johnd...@cisco.com>
Cc: dev@dpdk.org <dev@dpdk.org>, sta...@dpdk.org <sta...@dpdk.org>, Weiguo Li
<liwei...@xencore.cn>
Subject: [PATCH] net/enic: avoid extra unlock when setting MTU in enic
The 'set_mtu_done' goto statement is being executed in a context
where the 'mtu_lock' has not been previously locked.
To avoid the extra unlocking operation, replace the goto statement
with a return statement.
Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update")
Cc: sta...@dpdk.org
Signed-off-by: Weiguo Li <liwei...@xencore.cn>
---
.mailmap | 2 +-
drivers/net/enic/enic_main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.mailmap b/.mailmap
index 3f5bab26a8..b4f0ae26b8 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1500,7 +1500,7 @@ Waterman Cao <waterman....@intel.com>
Weichun Chen <weichunx.c...@intel.com>
Wei Dai <wei....@intel.com>
Weifeng Li <liweifen...@126.com>
-Weiguo Li <liw...@foxmail.com>
+Weiguo Li <liw...@foxmail.com> <liwei...@xencore.cn>
Wei Huang <wei.hu...@intel.com>
Wei Hu <w...@microsoft.com>
Wei Hu (Xavier) <xavier.hu...@huawei.com>
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index 19a99a82c5..a6aaa760ca 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -1639,7 +1639,7 @@ int enic_set_mtu(struct enic *enic, uint16_t new_mtu)
* packet length.
*/
if (!eth_dev->data->dev_started)
- goto set_mtu_done;
+ return rc;
/*
* The device has started, re-do RQs on the fly. In the process, we
--
2.34.1
