On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote:
-----Original Message----- From: Radu Nicolau <radu.nico...@intel.com> Sent: Tuesday, October 24, 2023 12:38 AM To: Wu, Jingjing <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com> Cc: dev@dpdk.org; Nicolau, Radu <radu.nico...@intel.com>; sta...@dpdk.org; Marchand, David <david.march...@redhat.com> Subject: [PATCH] net/iavf: fix Tx offloading flags check Use IAVF_TX_OFFLOAD_MASK flags instead of IAVF_TX_CKSUM_OFFLOAD_MASK. Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") Cc: sta...@dpdk.org Cc: david.march...@redhat.com Signed-off-by: Radu Nicolau <radu.nico...@intel.com> --- drivers/net/iavf/iavf_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index c6ef6af1d8..85f8c141ce 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -2664,7 +2664,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, l2tag1 |= m->vlan_tci; } - if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0) + if ((m->ol_flags & IAVF_TX_OFFLOAD_MASK) == 0)Not sure if this will break previous fix. Could you please provide some clarification regarding the specific offload flags that not in IAVF_TX_CKSUM_OFFLOAD_MASK, but you still don't want to skip?
A specific flag is RTE_ETH_TX_OFFLOAD_SECURITY, and because this is not contained in IAVF_TX_OFFLOAD_MASK the previous fix broke the inline crypto feature.
The previous fix was supposed to prevent reading l2_len and l3_len if no Tx offloads has been requested - but there are offloads that can be requested that are not in the IAVF_TX_CKSUM_OFFLOAD_MASK set.
goto skip_cksum; /* Set MACLEN */ -- 2.25.1
