On Mon, 23 Oct 2023 09:29:52 +0200
David Marchand <david.march...@redhat.com> wrote:
> On Fri, Oct 20, 2023 at 11:00 PM Stephen Hemminger
> <step...@networkplumber.org> wrote:
> >
> > The API's for rte_meter_trtcm were never properly flagged
> > as experimental; missing __rte_experimental but there was
> > an experimental comment in the docbook comment.
> > Remove the comment.
>
> While I don't object to this removal, I mentionned in previous mail
> that this commitlog is wrong.
> Those API were properly flagged as experimental.
>
> I'll update the commitlog myself...
Look at rte_meter in main branch. For example:
/**
* @warning
* @b EXPERIMENTAL: this API may change without prior notice
*
* trTCM RFC 4115 profile configuration
*
* @param p
* Pointer to pre-allocated trTCM profile data structure
* @param params
* trTCM profile parameters
* @return
* 0 upon success, error code otherwise
*/
int
rte_meter_trtcm_rfc4115_profile_config(
struct rte_meter_trtcm_rfc4115_profile *p,
struct rte_meter_trtcm_rfc4115_params *params);
The function is documented as experimental but the function
was not marked experimental in version.map or with __rte_experimental
attribute. Will reword the commit message to clarify.
