On Fri, Oct 20, 2023 at 11:01 PM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> The rte_security API's for macsec were added in 22.11.
> Therefore remove the experimental tag.
>
> There is also one helper function for setting packet
> metadata that should have been marked internal.
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> Acked-by: Akhil Goyal <gak...@marvell.com>
This patch does more than what is described in the commitlog (see below).
Please update the commitlog.
> ---
> lib/security/rte_security.h | 27 ---------------------------
> lib/security/version.map | 18 +++++++++---------
> 2 files changed, 9 insertions(+), 36 deletions(-)
>
> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h
> index d2d2af23d5d2..a19544906f21 100644
> --- a/lib/security/rte_security.h
> +++ b/lib/security/rte_security.h
> @@ -815,7 +815,6 @@ rte_security_session_create(void *instance,
> * - On success returns 0
> * - On failure returns a negative errno value.
> */
> -__rte_experimental
> int
> rte_security_session_update(void *instance,
> void *sess,
Not macsec related.
[snip]
> @@ -1059,7 +1042,6 @@ rte_security_session_fast_mdata_set(void *sess,
> uint64_t fdata)
> }
>
> /** Function to call PMD specific function pointer set_pkt_metadata() */
> -__rte_experimental
> int __rte_security_set_pkt_metadata(void *instance,
> void *sess,
> struct rte_mbuf *m, void *params);
Not macsec related, but this is probably the helper mentionned in commitlog.
> @@ -1230,16 +1212,12 @@ struct rte_security_stats {
> * - On success, return 0
> * - On failure, a negative value
> */
> -__rte_experimental
> int
> rte_security_session_stats_get(void *instance,
> void *sess,
> struct rte_security_stats *stats);
Not macsec related.
[snip]
> diff --git a/lib/security/version.map b/lib/security/version.map
> index e07fca33a1e6..54c9a556798d 100644
> --- a/lib/security/version.map
> +++ b/lib/security/version.map
> @@ -1,19 +1,12 @@
> DPDK_24 {
> global:
>
> + __rte_security_set_pkt_metadata;
> rte_security_capabilities_get;
> rte_security_capability_get;
> rte_security_session_create;
> rte_security_session_destroy;
> rte_security_session_get_size;
> -
> - local: *;
> -};
> -
> -EXPERIMENTAL {
> - global:
> -
> - __rte_security_set_pkt_metadata;
> rte_security_dynfield_offset;
If we mark rte_security_dynfield_offset stable, its accessor helper
(rte_security_dynfield) can be marked stable too.
> rte_security_macsec_sa_create;
> rte_security_macsec_sa_destroy;
> @@ -23,8 +16,15 @@ EXPERIMENTAL {
> rte_security_macsec_sc_stats_get;
> rte_security_session_stats_get;
> rte_security_session_update;
> - rte_security_oop_dynfield_offset;
>
> + local: *;
> +};
> +
> +EXPERIMENTAL {
> + global:
> +
> + # Added in 23.11
> + rte_security_oop_dynfield_offset;
> rte_security_rx_inject_configure;
> rte_security_inb_pkt_rx_inject;
Alphabetical order in the experimental section please.
--
David Marchand
