On Tue, 3 Oct 2023 11:44:16 +0100 Ferruh Yigit <ferruh.yi...@amd.com> wrote:
> On 10/2/2023 7:37 PM, Stephen Hemminger wrote: > > This patchset makes rte_ether_unformat_addr allow other formats > > for MAC address. Need to remove some inputs from existing > > cmdline_etheraddr test, and add a new test in test suite > > to cover this. There is some overlap between the two tests > > but that is fine. > > > > Stephen Hemminger (3): > > test: remove some strings from cmdline_etheraddr tests > > rte_ether_unformat: accept more inputs > > test: add tests for rte_ether routines > > > > Thanks Stephen, > > This enables using the API as replacement to the tap PMD's local parse > implementation: > https://patchwork.dpdk.org/project/dpdk/patch/20230323170145.129901-1-...@linux.vnet.ibm.com/ That looks good, but indentation is wrong and it duplicates a check for value == NULL which will cause a new Coverity warning.