On 9/28/2023 3:05 AM, Chaoyong He wrote: >> On 9/26/2023 3:49 AM, Chaoyong He wrote: >>> This patch series add the support of ipsec offload feature, includes: >>> * Implement the communication channel between PMD and firmware through >>> mailbox. >>> * Implement the ipsec offload related APIs based the security framework. >>> * Implement the ipsec packets process logics in the data path. >>> >>> --- >>> v2: >>> * Fix one spell error cause check warning. >>> * Try to fix one compile error in Alpine environment of CI. >>> --- >>> >>> Chang Miao (2): >>> net/nfp: initialize IPsec related content >>> net/nfp: create security session >>> >>> Shihong Wang (8): >>> mailmap: update contributor entry >>> net/nfp: add TLVs capability parsing >>> net/nfp: add mailbox to support IPsec offload >>> net/nfp: get security capabilities and session size >>> net/nfp: get IPsec Rx/Tx packet statistics >>> net/nfp: update security session >>> net/nfp: support IPsec Rx and Tx offload >>> net/nfp: destroy security session >>> >> >> Hi Chaoyong, >> >> Patchset looks good, but adding ipsec support to driver seems significant >> enough >> to document in the release notes, what do you think? > > Yeah, I agree. I will try to add that in the next version. > A separate commit for that or squash that into the final commit of this patch > series, > which one you think is better? >
Squashing to the most relevant commit it better, this creates a link between the documentation and the code which is useful when back tracing a feature in the git history.
