On Tue, Sep 19, 2023 at 3:25 AM Nicolas Chautru <nicolas.chau...@intel.com> wrote: > > This removes the specific capability and support of LTE Decoder > Soft Output option on the VRB1 PMD.
Please explain why such support is removed for this hw. > > Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com> > --- > drivers/baseband/acc/rte_vrb_pmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c > b/drivers/baseband/acc/rte_vrb_pmd.c > index 3c8f3409ed..e0f50460bd 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -1019,14 +1019,11 @@ vrb_dev_info_get(struct rte_bbdev *dev, struct > rte_bbdev_driver_info *dev_info) > RTE_BBDEV_TURBO_CRC_TYPE_24B | > RTE_BBDEV_TURBO_DEC_CRC_24B_DROP | > RTE_BBDEV_TURBO_EQUALIZER | > - RTE_BBDEV_TURBO_SOFT_OUT_SATURATE | > RTE_BBDEV_TURBO_HALF_ITERATION_EVEN | > RTE_BBDEV_TURBO_CONTINUE_CRC_MATCH | > - RTE_BBDEV_TURBO_SOFT_OUTPUT | > RTE_BBDEV_TURBO_EARLY_TERMINATION | > RTE_BBDEV_TURBO_DEC_INTERRUPTS | > RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN | > - > RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT | > RTE_BBDEV_TURBO_MAP_DEC | > RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP | > RTE_BBDEV_TURBO_DEC_SCATTER_GATHER, > @@ -1975,6 +1972,9 @@ enqueue_dec_one_op_cb(struct acc_queue *q, struct > rte_bbdev_dec_op *op, > struct rte_mbuf *input, *h_output_head, *h_output, > *s_output_head, *s_output; > > + /* Disable explictly SO for VRB 1. */ > + op->turbo_dec.op_flags &= ~RTE_BBDEV_TURBO_SOFT_OUTPUT; Can you explain why it is needed to filter this out? I did not find a clear description in the bbdev API. It would help if there were explicits references in doxygen of which capability is necessary for using flags/API. I was expecting that asking for RTE_BBDEV_TURBO_SOFT_OUTPUT to a driver is only allowed if rte_bbdev_op_cap contains it. With this assumption, it would be invalid for an application to request RTE_BBDEV_TURBO_SOFT_OUTPUT through rte_bbdev_enqueue_dec_ops. > + > desc = acc_desc(q, total_enqueued_cbs); > vrb_fcw_td_fill(op, &desc->req.fcw_td); > > -- > 2.34.1 > At this point of the series, the documentation still references RTE_BBDEV_TURBO_SOFT_OUTPUT as something supported by the vrb1 driver. -- David Marchand
